Skip to content

Use Logger implementation based on deployment configuration #27379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2020
Merged

Use Logger implementation based on deployment configuration #27379

merged 1 commit into from
Nov 13, 2020

Conversation

kandy
Copy link
Contributor

@kandy kandy commented Mar 21, 2020 •
edited by m2-assistant bot
Loading

Use Logger implementation based on deployment configuration

Manual testing scenarios (*)

  • Configure Magento to run in production mode
  • Add 'log' => [ 'type' => \Monolog\Logger::class, 'args' => ['name' => 'test']], line to app/etc/env.php file
  • Delete var/log folder
  • Run bin/magento s:s:d
  • Test that errors is logged to StdError stream
  • Test that var/log folder is not exists/empty

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Use Logger implementation based on deployment configuration #29600: Use Logger implementation based on deployment configuration

@m2-assistant
Copy link

m2-assistant bot commented Mar 21, 2020

Hi @kandy. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

lenaorobei
lenaorobei requested changes Mar 24, 2020
View reviewed changes
Copy link
Contributor

@lenaorobei lenaorobei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kandy,

Thanks for your contribution. Please address static builds failures.

@ghost ghost assigned lenaorobei Mar 24, 2020
@kandy
Copy link
Contributor Author

kandy commented Mar 25, 2020

@lenaorobei
CopyPaste fail is not related to my code at all
PhpStan fail report that there not exists classes in test that test error s logging on loading of not exists classes, so I believe we need ignore this errors

@lenaorobei
Copy link
Contributor

@kandy, agree with phpcpd, but for phpstan please add ignore annotation or this file to whitelist.

@kandy
Copy link
Contributor Author

kandy commented Mar 25, 2020

@lenaorobei Can you point me on documentation how to do it?

@kandy kandy requested a review from lenaorobei March 27, 2020 03:38
@lenaorobei
Copy link
Contributor

@magento run all tests

@lenaorobei
Copy link
Contributor

@kandy are you still up to finishing this PR?

@lenaorobei
Copy link
Contributor

@kandy please address tests failures

@kandy kandy closed this May 20, 2020
@m2-assistant
Copy link

m2-assistant bot commented May 20, 2020

Hi @kandy, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@kandy kandy reopened this May 20, 2020
@m2-assistant
Copy link

m2-assistant bot commented May 20, 2020

Hi @kandy. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@ghost ghost unassigned lenaorobei May 20, 2020
@kandy kandy closed this May 20, 2020
@m2-assistant
Copy link

m2-assistant bot commented May 20, 2020

Hi @kandy, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@kandy kandy reopened this May 23, 2020
@kandy
Copy link
Contributor Author

kandy commented May 25, 2020

@magento run Integration Tests

4 similar comments
@kandy
Copy link
Contributor Author

kandy commented Jun 24, 2020

@magento run Integration Tests

@kandy
Copy link
Contributor Author

kandy commented Jun 25, 2020

@magento run Integration Tests

@kandy
Copy link
Contributor Author

kandy commented Jun 25, 2020

@magento run Integration Tests

@kandy
Copy link
Contributor Author

kandy commented Jun 25, 2020

@magento run Integration Tests

@ihor-sviziev
Copy link
Contributor

@magento run all tests

@ihor-sviziev ihor-sviziev self-assigned this Oct 15, 2020
@ihor-sviziev ihor-sviziev added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Progress: review labels Oct 15, 2020
@ihor-sviziev
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests EE, WebAPI Tests

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8350 has been created to process this Pull Request

@engcom-Delta engcom-Delta self-assigned this Nov 11, 2020
@engcom-Delta
Copy link
Contributor

✔️ QA passed
Was checked case from Manual testing scenarios
Result:
✔️ Errors is logged to StdError stream when run magento commands
✔️ var/log folder is empty
image
image
image

@engcom-Delta engcom-Delta added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Nov 11, 2020
@engcom-Delta
Copy link
Contributor

Note: Automation tests are passed

magento-engcom-team pushed a commit that referenced this pull request Nov 13, 2020
@gabrieldagama
ENGCOM-8350: Use Logger implementation based on deployment configurat…
9711d3b 
…ion #27379
@magento-engcom-team magento-engcom-team merged commit 5439d55 into magento:2.4-develop Nov 13, 2020
@m2-assistant
Copy link

m2-assistant bot commented Nov 13, 2020

Hi @kandy, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@kandy kandy deleted the Logger branch November 13, 2020 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

@lenaorobei lenaorobei Awaiting requested review from lenaorobei

Assignees

@ihor-sviziev ihor-sviziev

@engcom-Delta engcom-Delta

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: category of expertise Award: test coverage Component: App Component: Logger improvement Priority: P3 May be fixed according to the position in the backlog. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Use Logger implementation based on deployment configuration
6 participants
@kandy @lenaorobei @sidolov @ihor-sviziev @magento-engcom-team @engcom-Delta